fix: package compiles again on Unity 6000.4 and newer#1735
Merged
Conversation
…6000.4+ Object.GetInstanceID() is obsolete-as-error (CS0619) starting Unity 6000.4, so the package failed to compile on Unity 6000.4+ git installs. The #1118 fix guarded ComponentPropertySerializer and HierarchyService but missed this call site. Apply the same UNITY_6000_4_OR_NEWER guard; the lower 32 bits of EntityId equal the legacy instance id, which keeps the cluster key semantics unchanged. Fixes #1732
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesRaycast cluster key compatibility
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
error CS0619: 'Object.GetInstanceID()' is obsoleteatRaycastGridAnnotator.cs:376, so git-URL installs from main were broken.Changes
UNITY_6000_4_OR_NEWERguard used by the Compile errors in Unity 6.5 due to obsolete APIs (CS0619: GetInstanceID & objectReferenceInstanceIDValue) #1118 fix to the one call site it missed. On 6000.4+ the cluster key is derived from the lower 32 bits ofEntityId, which equal the legacy instance id (this is exactly how Unity's ownGetInstanceID()compatibility shim is implemented), so clustering semantics are unchanged.Verification
RaycastGridAnnotator.cs:376.Fixes #1732
Summary
Updated
RaycastGridAnnotatorfor Unity 6000.4+ compatibility by deriving cluster keys from the lower 32 bits ofEntityId. Older Unity versions continue usingGetInstanceID().Verification
Fixes
#1732.